Fix issues with searching for files on ESGF #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 209 209
Lines 11340 11342 +2
=======================================
+ Hits 10378 10380 +2
Misses 962 962
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bouweandela
commented
Jan 9, 2023
| facets[key] = values[idx] | ||
| else: | ||
| logger.debug("Wrong dataset_id_template_ %s for dataset %s", | ||
| template, dataset_id) |
There was a problem hiding this comment.
Maybe I should do something smarter here..
valeriupredoi
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
this looks good to me @bouweandela - unless you want to do something smarter in there where you say that?
|
Thanks @valeriupredoi! Let's get this merged and I'll make a new pull request to do something smarter ;-) |
|
Thanks 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1861
Closes #1862
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: